After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644149 - CRITICAL: Tried to remove non-existing item from chooser
CRITICAL: Tried to remove non-existing item from chooser
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.91.x
Other Linux
: Normal critical
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-07 20:02 UTC by Bill Nottingham
Modified: 2011-03-07 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
greeter log for first crash (subsequent crashes have same backtrace/error) (32.78 KB, text/plain)
2011-03-07 20:02 UTC, Bill Nottingham 		  Details
greeter: don't tank if accounts service removes user we don't know about (1.71 KB, patch)
2011-03-07 21:47 UTC, Ray Strode [halfline] 		committed Details | Review

Description Bill Nottingham 2011-03-07 20:02:26 UTC 
Created attachment 182756 [details]
greeter log for first crash (subsequent crashes have same backtrace/error)

See log. On boot, the chooser constantly crashes in a loop upon drawing the
user list.

gdm-2.91.91-1.fc15
accountsservice-0.6.4-2.fc15
Comment 1 Bill Nottingham 2011-03-07 20:18:55 UTC 
Trigger appears to be 'root is logged in on a VT'.
Comment 2 Ray Strode [halfline] 2011-03-07 21:35:44 UTC 
This is the same old "you need accountsservice-0.6.4-3.fc15" bug i think.
Comment 3 Bill Nottingham 2011-03-07 21:40:50 UTC 
It persists with that version if root is logged in.
Comment 4 Bill Nottingham 2011-03-07 21:41:37 UTC 
...
gdm-simple-greeter[1990]: DEBUG(+): GdmUserChooserWidget: updating other user visibility
gdm-simple-greeter[1990]: DEBUG(+): GdmChooserWidget: selection change to list path '2'
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: Found x11 display of session '/org/freedesktop/
ConsoleKit/Session3': 
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: finding user root state 1
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: finding user root state 2
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: Looking for user root in accounts service
gdm-simple-greeter[1990]: DEBUG(+): ActUser: adding session /org/freedesktop/ConsoleKit/Session3
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: added session for user: (null)
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: Found x11 display of session '/org/freedesktop/ConsoleKit/Session4': :0
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: Found object path of user 'root': /org/freedesktop/Accounts/User0
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: finding user root state 3
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: user root fetched
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: finished handling request for user root
gdm-simple-greeter[1990]: DEBUG(+): ActUserManager: user changed
gdm-simple-greeter[1990]: DEBUG(+): GdmUserChooserWidget: font height 21; using icon size 63
gdm-simple-greeter[1990]: DEBUG(+): GdmUserChooserWidget: User added name:root logged-in:0 pixbuf:0xd64630
gdm-simple-greeter[1990]: CRITICAL: Tried to remove non-existing item from chooser
aborting...
gdm[2027]: ******************* START **********************************
...
Comment 5 Ray Strode [halfline] 2011-03-07 21:47:35 UTC 
The following fix has been pushed:
9ec8f69 greeter: don't tank if accounts service removes user we don't know about
Comment 6 Ray Strode [halfline] 2011-03-07 21:47:39 UTC 
Created attachment 182774 [details] [review]
greeter: don't tank if accounts service removes user we don't know about

The chooser right now will throw a critical if we try to remove an item
that doesn't exist.

There are some situations where users get removed from the account
service that we never added to the user list.  In those cases, we
need to be careful not to try to remove them to prevent crash-inducing
criticals.