After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644142 - StTextureCache: never return fullcolor icons for ST_ICON_SYMBOLIC
StTextureCache: never return fullcolor icons for ST_ICON_SYMBOLIC
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-07 17:52 UTC by Dan Winship
Modified: 2011-03-08 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
StTextureCache: never return fullcolor icons for ST_ICON_SYMBOLIC (2.93 KB, patch)
2011-03-07 17:52 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-03-07 17:52:04 UTC 
This is a problem in F14 at least (the panel icon gets a Fedora logo and
the Applications icon gets a Fedora-themed applications icon)
Comment 1 Dan Winship 2011-03-07 17:52:06 UTC 
Created attachment 182732 [details] [review]
StTextureCache: never return fullcolor icons for ST_ICON_SYMBOLIC

g_themed_icon_new_with_default_fallbacks() does not do what we want
with symbolic icons; if the user's icon theme is not "gnome", then it
will end up preferring a non-symbolic icon from the higher-level theme
over a symbolic icon from gnome-icon-theme-symbolic.

If the shell requests a symbolic icon, and there is only a
non-symbolic icon available, that should be considered a programmer
error, just like requesting a non-existent icon name. So change the
code to only look up "-symbolic" names when drawing an
ST_ICON_SYMBOLIC icon.
Comment 2 Owen Taylor 2011-03-07 20:23:42 UTC 
Review of attachment 182732 [details] [review]:

Seems fine to me
Comment 3 Dan Winship 2011-03-08 14:38:18 UTC 
Attachment 182732 [details] pushed as 026fc53 - StTextureCache: never return fullcolor icons for ST_ICON_SYMBOLIC