After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644121 - all: set the primary-toolbar style class on primary toolbars
all: set the primary-toolbar style class on primary toolbars
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-07 15:13 UTC by Cosimo Cecchi
Modified: 2011-03-08 13:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
all: set the primary-toolbar style class on primary toolbars (2.16 KB, patch)
2011-03-07 15:13 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2011-03-07 15:13:33 UTC
Themes like Adwaita will use this to paint the primary toolbar differently from other toolbars.
Comment 1 Cosimo Cecchi 2011-03-07 15:13:35 UTC
Created attachment 182713 [details] [review]
all: set the primary-toolbar style class on primary toolbars

So themes can override their appearance without hardcoding the widget
hierarchy.
Comment 2 Guillaume Desmottes 2011-03-07 15:29:14 UTC
Review of attachment 182713 [details] [review]:

++ please merge to master.
Comment 3 Cosimo Cecchi 2011-03-07 15:36:00 UTC
Thanks, pushed.
Comment 4 Guillaume Desmottes 2011-03-08 07:38:18 UTC
Humm I'm now having this error when starting Empathy:

** (empathy:29915): CRITICAL **: GtkBuilder Error (/home/cassidy/gnome/empathy/src/empathy-main-window.ui): Unhandled tag: 'style'


I'm using GTK+3 master.
Comment 5 Guillaume Desmottes 2011-03-08 13:47:25 UTC
Ok nevermind, I was linking on an older GTK+3.