GNOME Bugzilla – Bug 644097
Number with percentage should be given for translation
Last modified: 2011-09-14 13:45:25 UTC
The battery percentage is hardcoded here to use a percentage sign after the number: http://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js#n128 This is not used this way in all languages, so it should be passed for translation, like here: http://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js#n220
This is still an issue. This is the new reference: http://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js#n127 This now also doesn't use gettext: http://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js#n209 (maybe I misread before, but I thought it used a gettext call around the string "%d%%"). Not al languages use the percentage sign after the number, and some languages use a different character than '%', so please mark that string for translators.
'Not all' presumably means certain African languages? Positive examples are often more motivating than theoretical assertions.
Some I could find quickly: http://git.gnome.org/browse/gtk+/tree/po/eu.po#n665 http://git.gnome.org/browse/gtk+/tree/po/ar.po#n802 http://git.gnome.org/browse/gtk+/tree/po/ku.po#n571 (in case the line numbers change, search for the string "%d %%")
String freeze is in a few days. Would it be possible to look into this before then?
Created attachment 195868 [details] [review] power-status: Mark number with percentage for translation Some locales expect the percentage sign before the number while others use a different character, so mark it for translation. (In reply to comment #4) > String freeze is in a few days. Would it be possible to look into this before > then? Apparently not :(
Review of attachment 195868 [details] [review]: If I'm reading the code correctly, there are two places that need attention: http://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js#n121 http://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js#n194
Since the strings are not currently marked for translation, I think it is acceptable to fix this now, with an announcement to the i18n mailing list: https://live.gnome.org/TranslationProject/HandlingStringFreezes The following types of changes do not need explicit approval, however we would still very much like them to be announced so that we know about them: - Marking a message for translation that was previously not marked for translation by accident.
Created attachment 195874 [details] [review] power-status: Mark number with percentage for translation (In reply to comment #6) > Review of attachment 195868 [details] [review]: > > If I'm reading the code correctly, there are two places that need attention: > http://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js#n121 > http://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js#n194 Sorry, my bad - I was only grepping for '%%'
Comment on attachment 195874 [details] [review] power-status: Mark number with percentage for translation looks right
Note: From https://live.gnome.org/TranslationProject/HandlingStringFreezes : Marking a message for translation that was previously not marked for translation by accident does not need explicit approval, however we would still very much like them to be announced to gnome-i18n@ so that we know about them.
Attachment 195874 [details] pushed as e943dca - power-status: Mark number with percentage for translation