Created attachment 182671 [details] [review]
patch

http://git.collabora.co.uk/?p=user/danni/empathy.git;a=shortlog;h=refs/heads/find-channel-644085

Review of attachment 182671 [details] [review]:

::: src/empathy-chat-window.h
@@ +72,2 @@
 gboolean           empathy_chat_window_has_focus      (EmpathyChatWindow *window);
 EmpathyChat *      empathy_chat_window_find_chat      (TpAccount        *account,

Do we really need to keep empathy_chat_window_find_chat()? Or at least it seems it can become static.

(In reply to comment #2)
> Review of attachment 182671 [details] [review]:
> 
> Do we really need to keep empathy_chat_window_find_chat()? Or at least it seems
> it can become static.

Your choice :)

Let's make it static then.

Created attachment 185382 [details] [review]
updated patch

Done :)

Review of attachment 185382 [details] [review]:

Looks good.

SMS channels won't be implemented in 3.0, so I guess there is no point merging this before branching, right?

I branched so feel free to merge to master.

We do need this in 2.34 as well.

This whole approach is wrong, because channel paths can change across reconnects. A better approach would be to have a list of properties we should compare, for the moment I'm just planning on replacing this with a patch to check if the TpChat is an SMSChannel.

Created attachment 187259 [details] [review]
replacement for find channels nonsense

This goes on top of my SMS support work.

Review of attachment 187259 [details] [review]:

++