After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643945 - XDND: Allow workspace switching using the thumbnails
XDND: Allow workspace switching using the thumbnails
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-05 12:50 UTC by drago01
Modified: 2011-03-21 23:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
XDND: Allow workspace switching using the thumbnails (2.52 KB, patch)
2011-03-05 12:50 UTC, drago01
none Details | Review
XDND: Allow workspace switching using the thumbnails (3.54 KB, patch)
2011-03-05 12:57 UTC, drago01
needs-work Details | Review
XDND: Allow workspace switching using the thumbnails (2.97 KB, patch)
2011-03-21 22:21 UTC, drago01
committed Details | Review

Description drago01 2011-03-05 12:50:19 UTC
See patch.
Comment 1 drago01 2011-03-05 12:50:22 UTC
Created attachment 182545 [details] [review]
XDND: Allow workspace switching using the thumbnails

Currently activating a window on a different workspace requires very
long drag distances, which is very inconvenient to use.

Fix that by allowing switching workspaces using the thumbnails which is
consistent with window and launcher dnd and much easier to use.
Comment 2 drago01 2011-03-05 12:57:31 UTC
Created attachment 182547 [details] [review]
XDND: Allow workspace switching using the thumbnails

Currently activating a window on a different workspace requires very
long drag distances, which is very inconvenient to use.

Fix that by allowing switching workspaces using the thumbnails which is
consistent with window and launcher dnd and much easier to use.

---

Don't allow activating windows from the thumbnails, this conflicts
with the switch workspace behaviour and is confusing.
Comment 3 Owen Taylor 2011-03-05 19:05:32 UTC
Review of attachment 182547 [details] [review]:

Testing it out, I generally like the feel - it seems right to activate the workspaces immediately on hover rather than waiting for a timeout.... the only thing that I might wonder is if that will be annoying in multihead if you want to drag to and activate a window on a secondary monitor, but that's pretty much a corner case.

::: js/ui/panel.js
@@ +700,3 @@
+                        overviewShownID = Main.overview.connect('shown', function() {
+                            Main.overview.beginItemDrag(actor);
+                            Main.overview.disconnect(overviewShownID);

I don't like this, howver, it's:

 - Duplicated code (can obviously be fixed)
 - A hack
 - Looks a bit weird - since you go to the overview, then you secondarily slide the workspaces out

Why don't we wait until Alex's "Workspace/WorkspacesView zooming and positioning is insane in the brain" patches land and on top of that I dont' think it will be hard at all to come up with a patch where if we are in XDND we always have the thumbnails slide ot.
Comment 4 Alexander Larsson 2011-03-18 13:59:55 UTC
Bug 641877 has a patch that makes thumbnails always out if there is a monitor to the right.
Comment 5 drago01 2011-03-21 22:21:21 UTC
Created attachment 184016 [details] [review]
XDND: Allow workspace switching using the thumbnails

Currently activating a window on a different workspace requires very
long drag distances, which is very inconvenient to use.

Fix that by allowing switching workspaces using the thumbnails which is
consistent with window and launcher dnd and much easier to use.

---

*) Don't animate the thumbnails after opening the overview, but keep them open
Comment 6 Owen Taylor 2011-03-21 22:57:24 UTC
Review of attachment 184016 [details] [review]:

looks good to me and seems to work well in testing.
Comment 7 drago01 2011-03-21 23:05:11 UTC
Attachment 184016 [details] pushed as 528fc9b - XDND: Allow workspace switching using the thumbnails