GNOME Bugzilla – Bug 643820
control-alt-tab: pixel alignment wrong
Last modified: 2011-03-04 16:08:29 UTC
Text in the control-alt-tab dialog is not ending up on pixel boundaries. (1440x900 resolution here - if it's not easily reproducible could be resolution dependent.)
Created attachment 182444 [details] [review] CtrlAltTabPopup: Fix pixel aligment CtrlAltTabPopup was using a St.BoxLayout and relied on anchor_gravity center for positioning. This does not guarantee correct pixel aligment, so use a St.GenericContainer instead and do the positioning similar to that of the appSwitcher.
Created attachment 182445 [details] [review] CtrlAltTabPopup: Fix pixel alignment CtrlAltTabPopup was using a St.BoxLayout and relied on anchor_gravity center for positioning. This does not guarantee correct pixel alignment, so use a St.GenericContainer instead and do the positioning similar to that of the appSwitcher. --- Fix typos in subject / commit message.
Comment on attachment 182445 [details] [review] CtrlAltTabPopup: Fix pixel alignment >+ this.actor = new Shell.GenericContainer({ name: 'ctrlAltTabPopup', reactive: true }); nitpick: reactive should be on a new line >+ childBox.x2 = Math.min(childBox.x1 + primary.width - hPadding, childBox.x1 + childNaturalWidth); should not have the childBox.x1 term in the first condition. good to commit with those fixes (and the corresponding fix to altTab.js for childBox.x2)
Attachment 182445 [details] pushed as 03401bb - CtrlAltTabPopup: Fix pixel alignment