After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643820 - control-alt-tab: pixel alignment wrong
control-alt-tab: pixel alignment wrong
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-03 21:45 UTC by Owen Taylor
Modified: 2011-03-04 16:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
CtrlAltTabPopup: Fix pixel aligment (3.36 KB, patch)
2011-03-04 08:50 UTC, drago01
none Details | Review
CtrlAltTabPopup: Fix pixel alignment (3.36 KB, patch)
2011-03-04 08:53 UTC, drago01
committed Details | Review

Description Owen Taylor 2011-03-03 21:45:38 UTC
Text in the control-alt-tab dialog is not ending up on pixel boundaries. (1440x900 resolution here - if it's not easily reproducible could be resolution dependent.)
Comment 1 drago01 2011-03-04 08:50:45 UTC
Created attachment 182444 [details] [review]
CtrlAltTabPopup: Fix pixel aligment

CtrlAltTabPopup was using a St.BoxLayout and relied on anchor_gravity
center for positioning. This does not guarantee correct pixel aligment,
so use a St.GenericContainer instead and do the positioning similar to
that of the appSwitcher.
Comment 2 drago01 2011-03-04 08:53:41 UTC
Created attachment 182445 [details] [review]
CtrlAltTabPopup: Fix pixel alignment

CtrlAltTabPopup was using a St.BoxLayout and relied on anchor_gravity
center for positioning. This does not guarantee correct pixel alignment,
so use a St.GenericContainer instead and do the positioning similar to
that of the appSwitcher.

---

Fix typos in subject / commit message.
Comment 3 Dan Winship 2011-03-04 13:56:02 UTC
Comment on attachment 182445 [details] [review]
CtrlAltTabPopup: Fix pixel alignment

>+        this.actor = new Shell.GenericContainer({ name: 'ctrlAltTabPopup', reactive: true });

nitpick: reactive should be on a new line

>+        childBox.x2 = Math.min(childBox.x1 + primary.width - hPadding, childBox.x1 + childNaturalWidth);

should not have the childBox.x1 term in the first condition.

good to commit with those fixes (and the corresponding fix to altTab.js for childBox.x2)
Comment 4 drago01 2011-03-04 16:08:25 UTC
Attachment 182445 [details] pushed as 03401bb - CtrlAltTabPopup: Fix pixel alignment