After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643804 - Initial panel corner positions are wrong
Initial panel corner positions are wrong
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-03 17:52 UTC by Florian Müllner
Modified: 2011-03-03 21:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
panel: Use a constant for the panel startup animation time (1.04 KB, patch)
2011-03-03 17:52 UTC, Florian Müllner
committed Details | Review
panel: Include panel corners in startup animation (1.86 KB, patch)
2011-03-03 17:52 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2011-03-03 17:52:30 UTC
See patches.
Comment 1 Florian Müllner 2011-03-03 17:52:32 UTC
Created attachment 182384 [details] [review]
panel: Use a constant for the panel startup animation time
Comment 2 Florian Müllner 2011-03-03 17:52:36 UTC
Created attachment 182385 [details] [review]
panel: Include panel corners in startup animation

Commit b1654af4063 moved the panel positioning (and thus that of its
corners) before the panel startup animation. As the panel corners now
are mapped while the panel animation is active, the initial style-changed
signal which triggers another repositioning is received after the
initial layout and the corners end up at wrong positions.
To fix, animate the corner positions as well during the startup
animation - if anyone could actually see the animation, the corners
should animate with the panel anyway ...
Comment 3 Owen Taylor 2011-03-03 20:40:54 UTC
Review of attachment 182384 [details] [review]:

Sure
Comment 4 Florian Müllner 2011-03-03 21:45:12 UTC
Comment on attachment 182384 [details] [review]
panel: Use a constant for the panel startup animation time

Attachment 182384 [details] pushed as 6fbf8fa - panel: Use a constant for the panel startup animation time
Comment 5 Owen Taylor 2011-03-03 21:53:08 UTC
Review of attachment 182385 [details] [review]:

OK, as per discussion on IRC I think this works. There are subtilties about things competing against each other which aren't apparently from the code, but the code makes sense in isolation - as you say, the corners should animate.
Comment 6 Florian Müllner 2011-03-03 21:57:26 UTC
Attachment 182385 [details] pushed as d6e29be - panel: Include panel corners in startup animation