After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643738 - Icons in dash/app view/search results don't adjust to icon theme changes
Icons in dash/app view/search results don't adjust to icon theme changes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-03 00:21 UTC by Florian Müllner
Modified: 2011-03-04 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
base-icon: Always recreate icon texture on style changes (1.84 KB, patch)
2011-03-03 00:21 UTC, Florian Müllner 		needs-work Details | Review
base-icon: Always recreate icon texture on style changes (2.39 KB, patch)
2011-03-03 16:57 UTC, Florian Müllner 		accepted-commit_now Details | Review
base-icon: Always recreate icon texture on style changes (2.43 KB, patch)
2011-03-03 22:20 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-03-03 00:21:53 UTC 
See attached patch.
Comment 1 Florian Müllner 2011-03-03 00:21:56 UTC 
Created attachment 182318 [details] [review]
base-icon: Always recreate icon texture on style changes

Currently the icon texture is only updated on style changes when
the icon size is set from CSS and differs from the previously used
icon size.
As the style change may have been triggered by an icon theme change,
textures that are created for themed icons should always be recreated;
given that this is the case for most uses (with the exception of
file thumbnails), recreate the icon texture unconditionally to avoid
complexity.
Comment 2 Owen Taylor 2011-03-03 16:02:15 UTC 
Review of attachment 182318 [details] [review]:

can you rework _setIconSize into _createIconTexture? reads weird like this.
Comment 3 Florian Müllner 2011-03-03 16:57:30 UTC 
Created attachment 182362 [details] [review]
base-icon: Always recreate icon texture on style changes

(In reply to comment #2)
> can you rework _setIconSize into _createIconTexture? reads weird like this.

Sure.

(Alternatively I could use _updateIconTexture() instead and discard the changes to _init())
Comment 4 Owen Taylor 2011-03-03 18:21:21 UTC 
Review of attachment 182362 [details] [review]:

Looks good reading it, but before committing, can you add some logging to createIconTextureto make sure that the icon is loaded only once at creation time?
Comment 5 Florian Müllner 2011-03-03 22:20:26 UTC 
Created attachment 182407 [details] [review]
base-icon: Always recreate icon texture on style changes

(In reply to comment #4)
> Looks good reading it, but before committing, can you add some logging to
> createIconTextureto make sure that the icon is loaded only once at creation
> time?

Right - it is loaded once at creation time, and then recreated on style change when the actor is mapped. I can't think of anything which would require the texture before style-changed, so omit loading it in the constructor ...
Comment 6 Owen Taylor 2011-03-03 22:34:05 UTC 
Review of attachment 182407 [details] [review]:

Let's go with this, has some interaction with the question of when we emit ::style-set and the :first-child issue (bug 627083), but those issues are all over the code.
Comment 7 Florian Müllner 2011-03-04 00:44:26 UTC 
(In reply to comment #6)
> Let's go with this

OK.


Attachment 182407 [details] pushed as e01971e - base-icon: Always recreate icon texture on style changes