After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643682 - Disable keybindings message should ungrab keys
Disable keybindings message should ungrab keys
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2011-03-02 16:06 UTC by Daniel Drake
Modified: 2011-05-21 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (3.22 KB, patch)
2011-03-02 16:06 UTC, Daniel Drake 		reviewed Details | Review

Description Daniel Drake 2011-03-02 16:06:51 UTC 
Created attachment 182261 [details] [review]
fix

The "metacity-message disable-keybindings" action is currently only 'soft' in that it just causes Metacity to ignore keypresses; the keys themselves are left bound.

Sugar would like to use this message to actually disable the bindings *and* release the grabs so that it can implement its own Alt-Tab handler

This patch implements this. Based on earlier work by Bernie Innocenti.


(If this patch passes review, I have commit access)
Comment 1 Colin Walters 2011-05-13 18:31:50 UTC 
Did you ever look at:
https://bugzilla.gnome.org/show_bug.cgi?id=621686

I did that patch specifically for you guys; it seems a lot saner to me to have a metacity plugin which you can load once and disable the keybindings at startup before they're even grabbed, rather than having them all ungrabbed, then metacity get an X message and ungrab them.
Comment 2 Colin Walters 2011-05-18 00:43:27 UTC 
Review of attachment 182261 [details] [review]:

I didn't mean to sidetrack things totally with the plugin API discussion.   Anyways, I don't see anything obviously wrong with this patch, with the caveat that keys in window managers is a fantastic nest of complexity.

Does anything besides Sugar use this patch?  If not it seems very low risk to me, given it's an off-by-default bit in an effectively deprecated component of GNOME.

Do you have a GNOME account?  If so feel free to commit.
Comment 3 Daniel Drake 2011-05-21 16:52:33 UTC 
Thanks for the review! Pushed.