After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643390 - Recent API change in NetworkManager breaks the network panel (NM_DEVICE_TYPE_CDMA and NM_DEVICE_TYPE_GSM are no more)
Recent API change in NetworkManager breaks the network panel (NM_DEVICE_TYPE_...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-27 03:08 UTC by Daniel Trebbien
Modified: 2011-02-28 09:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for new NetworkManager API (3.86 KB, patch)
2011-02-27 17:58 UTC, Alexandre Rostovtsev 		none Details | Review
Patch (12.38 KB, patch)
2011-02-27 17:59 UTC, Daniel Trebbien 		none Details | Review

Description Daniel Trebbien 2011-02-27 03:08:11 UTC 
Commit 2140dad5e0de0033e5c9bb10bd77ecd80085e5a3 to NetworkManager (http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2140dad5e0de0033e5c9bb10bd77ecd80085e5a3) changed the definition of the `NMDeviceType` enum, among other things, which breaks at least `panels/network/panel-common.c` because `NM_DEVICE_TYPE_CDMA` and `NM_DEVICE_TYPE_GSM` are no longer defined.

This is a heads up...
Comment 1 Alexandre Rostovtsev 2011-02-27 17:58:37 UTC 
Created attachment 182045 [details] [review]
patch for new NetworkManager API

Since gnome-control-center was already treating NM_DEVICE_TYPE_CDMA and _GSM identically, we merely need to replace the checks for specific modem types with checks for NM_DEVICE_TYPE_MODEM.

This patch does so.
Comment 2 Daniel Trebbien 2011-02-27 17:59:40 UTC 
Created attachment 182046 [details] [review]
Patch
Comment 3 Alexandre Rostovtsev 2011-02-27 18:08:45 UTC 
Comment on attachment 182045 [details] [review]
patch for new NetworkManager API

Daniel Trebbien's patch is better :)
Comment 4 Daniel Trebbien 2011-02-27 18:10:31 UTC 
Wow! We submitted patches one minute apart :)
Comment 5 Richard Hughes 2011-02-28 09:58:44 UTC 
Applied, thanks guys.