After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643335 - smart dialog issues
smart dialog issues
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: Disks UI
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-25 22:18 UTC by Matthias Clasen
Modified: 2011-03-01 21:15 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
patch (1.81 KB, patch)
2011-03-01 20:34 UTC, Matthias Clasen
accepted-commit_now Details | Review

Description Matthias Clasen 2011-02-25 22:18:44 UTC
When running under gnome-shell, there are a number of issues:

- no title for the dialog
- no close button
- can't resize

All of these are the treatment that gnome-shell gives to parented dialogs.
So maybe the dialog should not be parented.
Comment 1 Matthias Clasen 2011-02-25 22:19:16 UTC
At least the close button issue is a blocker issue, I think.
Comment 2 Matthias Clasen 2011-03-01 20:34:41 UTC
Created attachment 182210 [details] [review]
patch

This patch changes the smart dialog and the benchmark dialog to be non-parented and have a close button.
Comment 3 David Zeuthen (not reading bugmail) 2011-03-01 20:43:35 UTC
Comment on attachment 182210 [details] [review]
patch

Makes sense to me. Please commit.