After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643300 - alt-tab: Enforce icon size
alt-tab: Enforce icon size
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-25 15:29 UTC by Florian Müllner
Modified: 2011-02-25 23:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
alt-tab: Enforce icon size (1.39 KB, patch)
2011-02-25 15:29 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-02-25 15:29:48 UTC 
When discussing the right approach to bug 642043, both Jon and Jimmac preferred scaling over padding ("preferred" as in "lesser evil"). The alt tab popup should behave consistently with the dash, so scale fallback icons there as well.
Comment 1 Florian Müllner 2011-02-25 15:29:50 UTC 
Created attachment 181921 [details] [review]
alt-tab: Enforce icon size

For applications with no proper desktop file, the window icon is
used as application icon in the tab switcher, but it won't have
the correct icon size. The current approach is to add additional
padding to these icons - the size turns out inconsistent with
other icons, but the icon appears sharp. For the dash it has been
decided that unsharp icons are less evil than differing icon sizes,
so icons are scaled up to the "right" size - for consistency, do the
same in the alt-tab switcher.
Comment 2 drago01 2011-02-25 22:23:04 UTC 
Review of attachment 181921 [details] [review]:

Patch looks good, the commit message is a bit to verbose imo, but well better too much information in it then none ;)
Comment 3 Florian Müllner 2011-02-25 23:11:36 UTC 
Attachment 181921 [details] pushed as c72241d - alt-tab: Enforce icon size