After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643294 - gnome-session shell end session dialog cancel button doesn't always cancel
gnome-session shell end session dialog cancel button doesn't always cancel
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-25 14:21 UTC by Ray Strode [halfline]
Modified: 2011-02-25 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: fix cancel button in logout dialog (2.41 KB, patch)
2011-02-25 15:10 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2011-02-25 14:21:49 UTC 
mccann noticed yesterday that if you have an open gedit with unsaved work and click cancel, then after canceling we pop up a new dialog.

This is probably a side effect of one of my recent clean ups of the gsm-shell code.
Comment 1 Ray Strode [halfline] 2011-02-25 15:10:35 UTC 
The following fix has been pushed:
bd55783 shell: fix cancel button in logout dialog
Comment 2 Ray Strode [halfline] 2011-02-25 15:10:37 UTC 
Created attachment 181919 [details] [review]
shell: fix cancel button in logout dialog

We were queuing an update from inhibitor changes that could
fire after the dialog was canceled, which would cause it to
reopen.

This commit makes sure the dialog is still open before processing
any queued inhibitor updates.