GNOME Bugzilla – Bug 643258
Overlay improvements
Last modified: 2011-02-25 14:52:37 UTC
Here are some patches I made to the overlay copy I use in Nautilus.
Created attachment 181885 [details] [review] overlay: use the internal child for scrolled window allocations
Created attachment 181886 [details] [review] overlay: use the natural size request instead of the minimum So that we don't break e.g. ellipsizable labels.
Created attachment 181887 [details] [review] overlay: make sure not to request negative allocations Or to allocate a child more than the available overall allocation.
Created attachment 181888 [details] [review] overlay: don't make 'relative-widget' construct only It can vary in time and it won't hurt.
Created attachment 181889 [details] [review] overlay-child: always allocate to the real widget the full allocation I don't get why we cache allocation here, and we should always just proxy the real widget allocation/request.
Review of attachment 181885 [details] [review]: I don't think this is good, the main point of this relative widget is to avoid special case the scrolled window. what you have to do is: add(sw, view) so the relative widget is already the child of the scrolled window.
Review of attachment 181886 [details] [review]: Go for it.
Review of attachment 181887 [details] [review]: Looks good.
Review of attachment 181888 [details] [review]: Fine by me.
Review of attachment 181889 [details] [review]: Go for it. I think this is a left over from when this widget made something with animations.
(In reply to comment #6) > I don't think this is good, the main point of this relative widget is to avoid > special case the scrolled window. what you have to do is: add(sw, view) so the > relative widget is already the child of the scrolled window. I think I might find another way of doing this in nautilus then. Closing this as FIXED now, as I pushed the other patches to master, thanks for the review.