After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643210 - Don't introduce global variables
Don't introduce global variables
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-24 17:27 UTC by Giovanni Campagna
Modified: 2011-02-24 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't declare global variables (2.50 KB, patch)
2011-02-24 17:27 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2011-02-24 17:27:13 UTC 
Nothing ever should be on the global objects.
Comment 1 Giovanni Campagna 2011-02-24 17:27:37 UTC 
Created attachment 181853 [details] [review]
Don't declare global variables

Fix a typo in panel.js, and ensure that all variables used in
functions are scoped to the block (using let), to avoid polluting
the global namespace.
Comment 2 Owen Taylor 2011-02-24 17:31:37 UTC 
Review of attachment 181853 [details] [review]:

Look like fine fixes
Comment 3 Giovanni Campagna 2011-02-24 20:28:13 UTC 
Attachment 181853 [details] pushed as 15ec185 - Don't declare global variables