After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643190 - make gsettings schemas nicer
make gsettings schemas nicer
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Config
unspecified
Other Linux
: Normal minor
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks:
 
 
Reported: 2011-02-24 13:41 UTC by Christian Persch
Modified: 2011-02-28 00:11 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Persch 2011-02-24 13:41:16 UTC
A few comments on the gsettings schemas.

 path="/desktop/gnome/peripherals/keyboard/">

The recommended convention is for paths to be of the /org/gnome/foo/bar style.
(same goes for all the other schemas too.)

    <key name="default-group" type="i">
      <default>-1</default>

Should maybe have a <range />.

    <key name="x" type="i">
      <default>-1</default>
      <_summary>The Keyboard Preview, X offset</_summary>
      <_description>The Keyboard Preview, X offset</_description>
    </key>
    <key name="y" type="i">
      <default>-1</default>
      <_summary>The Keyboard Preview, Y offset</_summary>
      <_description>The Keyboard Preview, Y offset</_description>
    </key>
    <key name="width" type="i">
      <default>-1</default>
      <_summary>The Keyboard Preview, width</_summary>
      <_description>The Keyboard Preview, width</_description>
    </key>
    <key name="height" type="i">
      <default>-1</default>
      <_summary>The Keyboard Preview, height</_summary>
      <_description>The Keyboard Preview, height</_description>

These should probably all have a <range />, like e.g. -1 .. maxint16 ?

  <schema gettext-domain="@GETTEXT_PACKAGE@" id="org.gnome.libgnomekbd.indicator" path="/desktop/gnome/peripherals/keyboard/indicator/">
    <key name="secondary" type="i">
      <default>0</default>

I guess negative numbers don't occur here, so maybe use "u"? Or a <range /> with min=0.

    <key name="font-size" type="i">
      <default>10</default>

Needs a <range />.
Comment 1 Sergey V. Udaltsov 2011-02-28 00:11:43 UTC
Should be ok now. Please check.