After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643137 - keynav should skip section headers
keynav should skip section headers
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Sidebar
2.91.x
Other Linux
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-23 22:13 UTC by Stefano Teso
Modified: 2011-02-26 10:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.48 KB, patch)
2011-02-23 22:15 UTC, Stefano Teso 		reviewed Details | Review
revised patch (2.41 KB, patch)
2011-02-24 14:32 UTC, Stefano Teso 		accepted-commit_now Details | Review

Description Stefano Teso 2011-02-23 22:13:48 UTC 
since section headers ('Bookmarks', 'Computer', etc.) cannot be selected with the mouse, IMO it makes sense to skip them when navigating with the keyboard as well.
Comment 1 Stefano Teso 2011-02-23 22:15:13 UTC 
Created attachment 181758 [details] [review]
patch

implements the proposed behavior
Comment 2 Cosimo Cecchi 2011-02-23 22:37:53 UTC 
Review of attachment 181758 [details] [review]:

Hey Stefano, nice patch; looks good. Why don't we do this also when the Ctrl modifier is active?
Comment 3 Stefano Teso 2011-02-24 14:32:13 UTC 
Created attachment 181829 [details] [review]
revised patch

Cosimo: as far as I can see there's no way to set the prelight entry using the GtkTreeView API (plus, the pre-selection feature in the places sidebar doesn't really have any use), so I assume you are asking to just remove the (modifiers == 0) clause from the conditions.  In this case, the attached patch should do the trick.
Comment 4 Cosimo Cecchi 2011-02-24 21:04:21 UTC 
Comment on attachment 181829 [details] [review]
revised patch

As you do that after we check for Alt+Down, looks good. Thanks!
Comment 5 Stefano Teso 2011-02-26 10:35:01 UTC 
Committed as 789d71e7edbc3f60668c305adb4da9bbdd94b4d6. Thanks again :-)