After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643110 - accessibility bus: should not allow all users to connect
accessibility bus: should not allow all users to connect
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Li Yuan
Depends on: 643454
Blocks:
 
 
Reported: 2011-02-23 18:42 UTC by Colin Walters
Modified: 2011-03-07 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Colin Walters 2011-02-23 18:42:39 UTC
<allow user="*"> is wrong - the accessibility bus should follow the *session* bus security model here and only allow the user to connect.
Comment 1 Mike Gorse 2011-02-24 18:01:26 UTC
Afaik the main reason for having this separate bus is to enable accessibility for administrative applications running as root.  So I _think_ it would work to allow root and the current user to connect but not other users.  This would require that the accessibility instance of dbus-daemon die with the session, since otherwise it stop working when, for instance, the gdm session ends and a user logs in, or a different user logs in.  I am not sure if this is happening right now--need to test and fix if necessary.
Comment 2 Colin Walters 2011-02-24 19:37:39 UTC
Note for the session bus, we don't currently explicitly allow root, though on Linux, it's possible for a process with CAP_SYS_ADMIN (not necessarily root/uid 0) to fake its credentials for the socket uid and connect.
Comment 3 Mike Gorse 2011-03-07 21:17:38 UTC
I've modified the .conf file so that only root can connect, rather than all users being able to connect.