After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643080 - Header collision between clutter-gtk-1.0 and clutter-gtk-0.10 due to include path order
Header collision between clutter-gtk-1.0 and clutter-gtk-0.10 due to include ...
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-games-general-maint
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-23 15:48 UTC by Nirbheek Chauhan
Modified: 2011-02-25 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change CFLAGS order, and keep the same LIBS order for consistency (2.18 KB, patch)
2011-02-23 15:53 UTC, Nirbheek Chauhan
committed Details | Review

Description Nirbheek Chauhan 2011-02-23 15:48:30 UTC
clutter-1.0 installs its headers in: /usr/include/clutter-1.0/clutter

clutter-gtk-0.10 installs its headers in: /usr/include/clutter-1.0/clutter-gtk

clutter-gtk-1.0 installs its headers in: /usr/include/clutter-gtk-1.0/clutter-gtk

If while building, `-I/usr/include/clutter-1.0 -I/usr/include/clutter-gtk-1.0` is passed, gcc will pick up clutter-gtk-0.10's headers, and the build will fail.

I talked to clutter upstream, and the only solution we could come up with was to add clutter-gtk-1.0's path in the build order *first*. This means that the PKG_CHECK_MODULES order is also important.

Attached below is a patch to change the order so that clutter-gtk-1.0 is always added first, for complete safety.

Thanks!
Comment 1 Nirbheek Chauhan 2011-02-23 15:53:00 UTC
Created attachment 181708 [details] [review]
Change CFLAGS order, and keep the same LIBS order for consistency
Comment 2 Christian Persch 2011-02-23 16:40:43 UTC
Comment on attachment 181708 [details] [review]
Change CFLAGS order, and keep the same LIBS order for consistency

Please commit to master. Thanks!
Comment 3 Thomas Andersen 2011-02-23 22:35:16 UTC
I just pushed it to master:
http://git.gnome.org/browse/gnome-games/commit/?id=705397f479f758a6eae767aad84e13b10ca25f46

It was causing problems on the buildbots that I was never able to figure out. Thanks a lot Nirbheek!