After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643078 - Header collision between clutter-gtk-1.0 and clutter-gtk-0.10 due to include path order
Header collision between clutter-gtk-1.0 and clutter-gtk-0.10 due to include ...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-23 15:26 UTC by Nirbheek Chauhan
Modified: 2011-02-24 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change PKG_CHECK_MODULES order to include clutter-gtk-1.0 first. (1.65 KB, patch)
2011-02-23 15:28 UTC, Nirbheek Chauhan
none Details | Review
Change PKG_CHECK_MODULES order to include clutter-gtk-1.0 first. (903 bytes, patch)
2011-02-23 15:50 UTC, Nirbheek Chauhan
none Details | Review

Description Nirbheek Chauhan 2011-02-23 15:26:38 UTC
clutter-1.0 installs its headers in: /usr/include/clutter-1.0/clutter

clutter-gtk-0.10 installs its headers in: /usr/include/clutter-1.0/clutter-gtk

clutter-gtk-1.0 installs its headers in: /usr/include/clutter-gtk-1.0/clutter-gtk

If while building, `-I/usr/include/clutter-1.0 -I/usr/include/clutter-gtk-1.0` is passed, gcc will pick up clutter-gtk-0.10's headers, and the build will fail.

------------
empathy-map-view.o: In function `create_marker':
/home/nirbheek/empathy-2.91.90/src/empathy-map-view.c:273: undefined reference to `GTK_CLUTTER_TEXTURE'
collect2: ld returned 1 exit status
make[1]: *** [empathy] Error 1
make: *** [all] Error 2
------------

I talked to clutter upstream, and the only solution we could come up with was to add clutter-gtk-1.0's path in the build order *first*. This means that the PKG_CHECK_MODULES order is also important.

Attached below is a patch to change the order so that clutter-gtk-1.0 is always added first, for complete safety.

Thanks!
Comment 1 Nirbheek Chauhan 2011-02-23 15:28:13 UTC
Created attachment 181705 [details] [review]
Change PKG_CHECK_MODULES order to include clutter-gtk-1.0 first.
Comment 2 Nirbheek Chauhan 2011-02-23 15:50:37 UTC
Created attachment 181707 [details] [review]
Change PKG_CHECK_MODULES order to include clutter-gtk-1.0 first.

Oops, attached the wrong patch last time...
Comment 3 Guillaume Desmottes 2011-02-24 10:44:21 UTC
Merged to master; thanks a lot for the patch!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.