After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643062 - polkit: don't show authentication dialog until needed
polkit: don't show authentication dialog until needed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-23 13:50 UTC by David Zeuthen (not reading bugmail)
Modified: 2011-02-23 19:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (6.12 KB, patch)
2011-02-23 18:37 UTC, David Zeuthen (not reading bugmail) 		committed Details | Review

Description David Zeuthen (not reading bugmail) 2011-02-23 13:50:11 UTC 
See https://bugs.freedesktop.org/show_bug.cgi?id=27788#c1 for details.

In particular, we should never bring up the dialog if there is no password on the account. While this sounds like a weird corner case, it's not.. the Live CD, for example, does not have a root password.

Btw, this should also avoid the initial dialog resize.. e.g. right now the authentication dialog appears and a split-second later we put in the StEntry widget.

I will work on a patch for this.
Comment 1 David Zeuthen (not reading bugmail) 2011-02-23 18:37:07 UTC 
Created attachment 181733 [details] [review]
Patch

Here's a patch to fix this problem
Comment 2 Owen Taylor 2011-02-23 19:37:23 UTC 
Review of attachment 181733 [details] [review]:

Looks fine to me.
Comment 3 David Zeuthen (not reading bugmail) 2011-02-23 19:49:26 UTC 
Comment on attachment 181733 [details] [review]
Patch

Committed. Thanks!