After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643007 - polkit: return error when authentication dialog is dismissed
polkit: return error when authentication dialog is dismissed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-22 21:57 UTC by David Zeuthen (not reading bugmail)
Modified: 2011-02-23 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (6.84 KB, patch)
2011-02-22 21:58 UTC, David Zeuthen (not reading bugmail) 		committed Details | Review

Description David Zeuthen (not reading bugmail) 2011-02-22 21:57:30 UTC 
This allows PolicyKit applications to disambiguate between when the
authentication dialog is dismissed versus when authentication fails
(e.g. the wrong password has been entered).

See https://bugs.freedesktop.org/show_bug.cgi?id=30653 for more
information.
Comment 1 David Zeuthen (not reading bugmail) 2011-02-22 21:58:26 UTC 
Created attachment 181645 [details] [review]
Patch
Comment 2 David Zeuthen (not reading bugmail) 2011-02-22 21:59:35 UTC 
This patch also works on polkit 0.100 - it does not depend on the patch from the fdo bug reference in comment 0. So it's safe to commit right away.
Comment 3 Owen Taylor 2011-02-23 15:43:26 UTC 
Review of attachment 181645 [details] [review]:

Not a fan of functions taking multiple booleans 'doThis(false, true);', but within one module and not part of the API it's OK, not really worth making it fancy.

(Probably what we'd do for an intermodule-api is use an object like  { keepVisible: false, dismissed: true })
Comment 4 David Zeuthen (not reading bugmail) 2011-02-23 16:04:09 UTC 
Comment on attachment 181645 [details] [review]
Patch

Committed. Thanks.