After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643001 - panel: Move panel border into the background
panel: Move panel border into the background
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-22 21:14 UTC by Florian Müllner
Modified: 2011-02-23 16:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
panel: Move panel border into the background (4.95 KB, patch)
2011-02-22 21:15 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2011-02-22 21:14:56 UTC
See attached patch.
Comment 1 Florian Müllner 2011-02-22 21:15:00 UTC
Created attachment 181639 [details] [review]
panel: Move panel border into the background

In the mockups the bottom border of active panel buttons is drawn
on top of the panel's border. To get this effect, move the panel
border into the background, so that it is not subtracted from the
vertical space given to the buttons. Adjust the drawing of the rounded
corners to reflect that change.
Comment 2 Owen Taylor 2011-02-23 16:13:53 UTC
Review of attachment 181639 [details] [review]:

This looks significantly better and is pretty clean code-wise. There's likely some performance hit from using a texture to draw the top panel, but since it's just one texture that we scale on the GPU when we draw, it shouldn't be too bad.
Comment 3 Florian Müllner 2011-02-23 16:40:14 UTC
Attachment 181639 [details] pushed as 9a048af - panel: Move panel border into the background