GNOME Bugzilla – Bug 642963
[dvdemux] time based upstream seek
Last modified: 2011-03-11 12:49:20 UTC
Created attachment 181586 [details] [review] dotime based seeks if upstream can handle it This patch adds time based upstream element seeks to dv demuxer element. It does so by first quering for the seek supported method before passing the event on or converting it.
The logic should be as follow: If (seek format time) ret = push_it_upstream() if ret == FALSE ret = do what's done right now return ret
Created attachment 181681 [details] [review] Updated patch to follow the suggested logic
commit d4eaff5e88c9b34a9e33ddaa9bb83859b2c37446 Author: Carsten Kroll <car@ximidi.com> Date: Thu Feb 24 13:56:04 2011 +0100 dvdemux: First try if upstream handles TIME seeks before handling them here Fixes bug #642963.
Comment on attachment 181681 [details] [review] Updated patch to follow the suggested logic Please use "git format-patch" style patches in the future
Created attachment 183049 [details] [review] fixes ref count issues introduced with previous patch
Review of attachment 183049 [details] [review]: Doesn't look right. Will do some more analysis of the issue.
gst_dvdemux_handle_push_seek() is not supposed to take ownership of the event. This fixes it, and another memory leak that was caused by assuming that the function takes ownership of the event. commit bc6c1bbbaba337538fd9cbaa307d6233ee03db4b Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Fri Mar 11 13:46:05 2011 +0100 dvdemux: Fix refcount issues with the seek event Fixes bug #642963.