GNOME Bugzilla – Bug 642918
Sensitivity of buttons sometimes screws up
Last modified: 2011-03-30 15:14:21 UTC
Sometimes buttons screw up their sensitivity. I tried to write a reduced testcase for this bug, but failed, because it seems to be there only with somewhat complex UI layouts. An example of where I've seen this reliably is Totem's sidebar 'Save playlist as' button; another example is the Control Center 'Region and Language' layouts (in the buttons below the treeview). It also happens in nautilus back/forward actions when you use split pane.
commit 0bfc95faa35ec5ac1a0220d04cc0c126acb034b5 Author: Benjamin Otte <otte@redhat.com> Date: Wed Mar 30 16:38:45 2011 +0200 widget: Propagate the right states to the widget when setting the parent commit 1e4396535065434c352881df8c26e050292c8c62 Author: Benjamin Otte <otte@redhat.com> Date: Wed Mar 30 16:15:21 2011 +0200 widget: Get rid of parent_sensitive flag Instead rely on state_flags & GTK_STATE_FLAG_INSENSITIVE to tell us if a widget is sensitive. This has the huge benefit that the way the widget is actually rendered corresponds to the return value of gtk_widget_is_sensitive(). As a side effect, we do not ever allow unsetting the GTK_STATE_FLAG_INSENSITIVE for a widget the is set to not be sensitive (via gtk_widget_set_sensitive()). This way we stop propagation of making stuff sensitive at insensitive widgets.