GNOME Bugzilla – Bug 642907
add input layout lets me add the same layout twice
Last modified: 2011-02-26 02:06:29 UTC
The add input layout lets me add the same layout twice (by mistake). It shouldn't. Probably good to say in the "add layout" list something like "Already added" and make the item insensitive.
Is is really impossible use case? Is this combination absolutely useless: us ru us de
Not useless, but given that this would waste one of the "slots" in XKB, it's of the very dubious kind.
Well, in general you are right. But for particular person that limitation may be not a concern - as long as he can do that thing... I don't know really. It is not a problem to add that check, technically...
The potential for annoyance is much greater in my estimation than any potential utility.
I would not argue, as I said.. I just would appreciate if you elaborate - what kind of annoyance that could cause?
This bug for example. I accidentally added the same layout twice. And was annoyed by the software that let that happen.
What exactly annoyed you, functionally?
I mean - you did not get broken or useless kbd config, right?
What do you think about the following rule: two consecutive identical layouts are forbidden, but if they are not consecutive, it is ok? So "us,ru,us,de" would be ok, but "us,de,de" would be impossible.
It still doesn't make any sense to allow this in the UI itself. The most likely reason why users would end up in this situation is when they make a wrong move. We shouldn't allow adding 2 of the same layout in the UI, people can always hit GSettings directly for that.
Ok, if it can be done through GSettings - so be it. I committed the code that disables the "Add" button if the layout/variant selected in the list cannot be added (because it is already there).