After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642884 - Passwords without usernames are not saved
Passwords without usernames are not saved
Status: RESOLVED DUPLICATE of bug 698866
Product: epiphany
Classification: Core
Component: General
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-21 15:54 UTC by Paul van der Vlis
Modified: 2013-05-03 18:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Save passwords for credentials forms without username field (5.00 KB, patch)
2011-03-16 08:29 UTC, Alexandre Mazari 		none Details | Review
Save passwords for credentials forms without username field (4.87 KB, patch)
2011-03-16 08:37 UTC, Alexandre Mazari 		reviewed Details | Review

Description Paul van der Vlis 2011-02-21 15:54:48 UTC 
Hello,

Epiphany does not save a password when there is no username on the site. 

The webinterface of my router has only a password field, no username field.

With regards,
Paul van der Vlis.
Comment 1 Alexandre Mazari 2011-03-16 08:29:22 UTC 
Created attachment 183493 [details] [review]
Save passwords for credentials forms without username field

Fix for
Comment 2 Alexandre Mazari 2011-03-16 08:37:55 UTC 
Created attachment 183495 [details] [review]
Save passwords for credentials forms without username field

Remove g_printing

Fix for #642884
Comment 3 Xan Lopez 2011-06-07 14:32:30 UTC 
Review of attachment 183495 [details] [review]:

::: embed/ephy-web-view.c
@@ +619,3 @@
+  if (fill_data->username_node)
+    g_object_set (fill_data->username_node,
+                  "value", keyring_data->user, NULL);

Shouldn't we check here that the keyring data wasn't stored as "bogus"? The page might have changed since we saved things.

@@ +797,3 @@
   hostname = ephy_string_get_host_name (store_data->uri);
+  if (hostname == NULL)
+    hostname = g_strdup (store_data->uri);

Mmm, this seems unrelated?
Comment 4 Gustavo Noronha (kov) 2013-05-03 18:59:34 UTC 

*** This bug has been marked as a duplicate of bug 698866 ***