Created attachment 181456 [details] [review]
css: Adjust tooltip style

Update the tooltip style to match current mockups.

Created attachment 181457 [details] [review]
dash: Show tooltips on hover

As dash items no longer show application names, display names as
tooltips on hover.

I didn't really consider those to be tooltips per se.  But after trying it, a few comments:

 * It feels a bit strange to have the tips left aligned under the dash items.  I think centering feels better (when it fits at least)
 * Feels a bit strange to have the tips disappear when I navigate into the popup menu.  One reason I'd like the titles to feel more like part of the icon.
 * They only seem to be shown on enter events when the menu is not up.  So I don't see a title when I do:
   - go to launcher 1
    (title appears)
   - right click
    (menu appears)
   - move to another icon
    (title disappears)
   - right click on other icon
    (first menu disappears)
   - right click again
    (new menu appears - but no title)

(also after doing all that I noticed I wasn't able to click on the Activities item to leave the overview.

(In reply to comment #3)
> I didn't really consider those to be tooltips per se.  But after trying it, a
> few comments:
> 
>  * It feels a bit strange to have the tips left aligned under the dash items. 
> I think centering feels better (when it fits at least)

Looks like you don't have anything in the dash which fits centered ;-)

Seriously, it only falls back to left-aligning if there's not enough space to center ...


>  * Feels a bit strange to have the tips disappear when I navigate into the
> popup menu.  One reason I'd like the titles to feel more like part of the icon.

Mhhh, OK. We can't _really_ make the title a part of the icon as it would affect the dash's size; But some custom tooltip-like implementation should be possible ...


>  * They only seem to be shown on enter events when the menu is not up.  So I
> don't see a title when I do:
> [...]
> (also after doing all that I noticed I wasn't able to click on the Activities
> item to leave the overview.

That's actually the popup code blocking events (e.g. the activities button won't work either if some panel menu is up)

*** Bug 645163 has been marked as a duplicate of this bug. ***

Obviously a pretty trivial patch and safe if tooltips are safe. Noticed testing:

 - I think it looks bad to show these tooltips without a hover timeout - very busy - we should obey the GtkSetting for this. (I wouldn't attempt to implement a browse mode where once one tooltip is up other tooltips show without a delay - since the tooltips overlap adjacent items, it doesn't work as wel as it does for a toolbar)

 - If the dash isn't on the leftmost monitor, tooltips do lap off the side of the monitor - we probably need a st_set_tooltip_constrain_function (ClutterStage *stage, fn) that can use the mutter or GTK+ multihead functions to do constrains.

 - Need to fix things so that while the menu is up, the tooltip is always up, and doesn't pop down until the menu pops down. May need to track down what is going on with:

        this._eventCaptureId = global.stage.connect('captured-event', Lang.bind(this, this._onEventCapture));
        // captured-event doesn't see enter/leave events
        this._enterEventId = global.stage.connect('enter-event', Lang.bind(this, this._onEventCapture));
        this._leaveEventId = global.stage.connect('leave-event', Lang.bind(this, this._onEventCapture));
        this._keyFocusNotifyId = global.stage.connect('notify::key-focus', Lang.bind(this, this._onKeyFocusChanged));

doesn't make a ton of sense - since connecting to the stage isn't the same as connecting to the stage at capture phase.

Created attachment 184059 [details] [review]
StTooltip: use a timeout like GtkTooltip

Here's a patch to add the timeout behavior - I think it makes the labels
for the dash items much less intrusive and annoying.

====

Instead of showing tooltips immediately on hover, wait until a timeout
after the last motion (timeout is given by the gtk-tooltip-timeout
GtkSetting.)

Created attachment 184071 [details] [review]
appDisplay: show hover and tooltip while the menu is up

While we have menu for an app icon open, we want to show the prelight
for the item instead of removing the prelight when the user mouses
away from the item and into the menu, and if there's a tooltip
(like for the dash), we want to show the tooltip immediately when
the menu is popped up.

Created attachment 184072 [details] [review]
popupMenu: Add the ability to block sending events to the source actor

It can be useful to avoid sending enter/leave events to the source actor
of a menu: this would be the case when the source actor isn't a menu item
that should participate in menu navigation but rather is some object
(like an app icon) that we want to indicate corresponds to the menu.

Review of attachment 184072 [details] [review]:

looks right

Review of attachment 184059 [details] [review]:

Looks good.

Attachment 181456 [details] pushed as 661ea90 - css: Adjust tooltip style
Attachment 181457 [details] pushed as 4a93ce7 - dash: Show tooltips on hover
Attachment 184059 [details] pushed as a5d3259 - StTooltip: use a timeout like GtkTooltip
Attachment 184071 [details] pushed as 0207825 - appDisplay: show hover and tooltip while the menu is up
Attachment 184072 [details] pushed as bea2d40 - popupMenu: Add the ability to block sending events to the source actor