GNOME Bugzilla – Bug 642865
Chat window close button is huge
Last modified: 2011-02-21 15:14:01 UTC
Here you have one that works only with gtk3: http://git.gnome.org/browse/gedit/tree/gedit/gedit-close-button.c and another that works with 2 - 3: http://git.gnome.org/browse/gnome-terminal/tree/src/terminal-close-button.c
Are you refering about the close button in chat tabs? Also, we are trying to avoid introducing new GPL code to Empathy (the goal being to be able to move code to a future telepathy-gtk library); any chance to have a LGPL version of gedit's code?
yes, the close button in the tabs. You have my agree to relicense it as lgpl, although you need it also from paolo
I am fine with relicensing to lgpl
Great, thanks guys. Can you please update the license in gedit first so Empathy can just ship a bare copy of it?
We need the approval of those people as well: cassidy@cass-x200s:~/gnome/gedit $ git shortlog -s gedit/gedit-close-button.c 1 Garrett Regier 5 Ignacio Casal Quinteiro 1 Jesse van den Kieboom 1 Paolo Borelli 1 Steve Frécinaux
Created attachment 181460 [details] [review] gedit-close-button: relicense to LGPL If/when all the authors agreed, I already have a patch ready for the relicensing.
Ignacio told me it was ok so I pushed the change.
Created attachment 181463 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/gedit-button-642865 src/Makefile.am | 2 + src/empathy-chat-window.c | 25 ++------------ src/gedit-close-button.c | 80 +++++++++++++++++++++++++++++++++++++++++++++ src/gedit-close-button.h | 60 +++++++++++++++++++++++++++++++++ 4 files changed, 146 insertions(+), 21 deletions(-)
merged to master. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
For the record, I'm ok with the license change.