Bug 642788 - Account for idle time when starting a typing break
Account for idle time when starting a typing break
Status: RESOLVED FIXED
Product: DrWright
Classification: Other
Component: general
master
Other Linux
: Normal normal
: ---
Assigned To: drwright-maint
drwright-maint
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-02-19 23:55 UTC by Christopher Aillon
Modified: 2011-02-21 02:18 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.72 KB, patch)
2011-02-19 23:56 UTC, Christopher Aillon 		none Details | Diff | Review
patch v2 (5.77 KB, patch)
2011-02-20 04:30 UTC, Christopher Aillon 		committed Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Christopher Aillon 2011-02-19 23:55:31 UTC 
If the user has been idle for a while when the typing break starts, it
should be taken into account.  Otherwise, we can get into a situation
where 8 minutes before a 10 minute break starts, the user goes idle for
10 minutes, and returns to the computer to find out they still have a
full break remaining.
Comment 1 Christopher Aillon 2011-02-19 23:56:04 UTC 
Created attachment 181373 [details] [review]
patch
Comment 2 Christopher Aillon 2011-02-20 04:30:26 UTC 
Created attachment 181376 [details] [review]
patch v2

Forgot to initialize the new priv member.
Comment 3 Christian Persch 2011-02-20 21:42:24 UTC 
Comment on attachment 181376 [details] [review]
patch v2

Thanks! Looks fine to me, please push to master.
Comment 4 Christopher Aillon 2011-02-21 02:18:37 UTC 
Comment on attachment 181376 [details] [review]
patch v2

Pushed dca6f0e2f0677acae7eb43b62e8aecba1d94787d
Note You need to log in before you can comment on or make changes to this bug.