After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642782 - [patch] gail_misc_buffer_get_run_attributes doesn't set background-gdk and foreground-gdk
[patch] gail_misc_buffer_get_run_attributes doesn't set background-gdk and fo...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Accessibility
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-02-19 22:24 UTC by Daniel Garcia
Modified: 2011-02-20 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
getting background-gdk and foreground-gdk correctly (1.87 KB, patch)
2011-02-19 22:24 UTC, Daniel Garcia 		none Details | Review

Description Daniel Garcia 2011-02-19 22:24:34 UTC 
Created attachment 181363 [details] [review]
getting background-gdk and foreground-gdk correctly

In gail_misc_buffer_get_run_attributes there's two calls to g_object_get (tag, ATTR, &c, NULL); to get "background-gdk" and "foreground-gdk". g_object_get should receive a pointer to the stored data and it will create a new object that we should free.

Currently "c" is declared like "GdkColor c" and it should be declared as "GdkColor *c".
Comment 1 Matthias Clasen 2011-02-20 14:49:44 UTC 
Thanks, committed.