After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642672 - Fix workspace thumbnails in RTL locales
Fix workspace thumbnails in RTL locales
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Florian Müllner
gnome-shell-maint
Depends on:
Blocks: 641881
 
 
Reported: 2011-02-18 14:46 UTC by Owen Taylor
Modified: 2011-02-18 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix workspace thumbnails in RTL locales (4.70 KB, patch)
2011-02-18 14:46 UTC, Owen Taylor 		accepted-commit_now Details | Review
Fix workspace thumbnails in RTL locales (4.81 KB, patch)
2011-02-18 15:49 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2011-02-18 14:46:01 UTC 
Here's the fix for RTL problems noted in the review of
Bug 641881. The dash always needs a similar fix to its CSS if this is the
way we want to handle it code-style wise.
Comment 1 Owen Taylor 2011-02-18 14:46:03 UTC 
Created attachment 181216 [details] [review]
Fix workspace thumbnails in RTL locales

We need slightly different CSS and positioning logic for
the workspace thumbnails list when it is on the left side of the
screen.
Comment 2 Florian Müllner 2011-02-18 15:32:43 UTC 
Review of attachment 181216 [details] [review]:

Looks good.

::: data/theme/gnome-shell.css
@@ +273,3 @@
 }
 
+.workspace-thumbnails-background.rtl {

I actually like the approach in bug 584662 of automagically assigned :rtl/:ltr pseudo classes which can be used if different CSS is required; not sure if it's worth waiting for that patch to be updated, but we could follow the pseudo-class style here anyway.
Comment 3 Owen Taylor 2011-02-18 15:49:16 UTC 
Created attachment 181221 [details] [review]
Fix workspace thumbnails in RTL locales

Thought "would be nice if this was an automatic pseudo-class" but had no
idea we still had a bug outstanding with patch in that direction. Redone
here using a manual pseudo-class rather than class - I'd rather get something
in now while I remember what the CSS differences need to be.
Comment 4 Florian Müllner 2011-02-18 15:58:05 UTC 
Review of attachment 181221 [details] [review]:

(In reply to comment #3)
> I'd rather get something in now while I remember what 
> the CSS differences need to be.

Sure, I'll do the same for the dash then.
Comment 5 Owen Taylor 2011-02-18 16:38:12 UTC 
Attachment 181221 [details] pushed as bff027c - Fix workspace thumbnails in RTL locales