After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642642 - Missed include in gtk/gtkmodules.c
Missed include in gtk/gtkmodules.c
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.24.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-02-18 03:52 UTC by Fan, Chun-wei
Modified: 2011-02-19 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Fan, Chun-wei 2011-02-18 03:52:34 UTC 
Hi,

(This is in response to the updates applied in commit 64adba6e3e44551a99dfae9e9198f7645c7bec35-"Extend the mixed-dependency check to modules as well" on 2011-02-08 23:02:48 (GMT))

I have applied the patches to the sources to 2.24.0 from the GIT commits, and it seems that the change in gtk/gtkmodules.c would trigger a C4013 warning/error for _gtk_module_has_mixed_deps under Visual C++ (which is probably a "implicit declaration of ..." for GCC users).

It seems that the gtkmain.h header needs to be included in that gtk/gtkmodules.c as well to remedy that (I did so after the line "#include "gtkalias.h" but am not sure whether it is the right place).

Thank you!