After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642638 - Provide gsd-xrandr icons (as links to preferences-desktop-display)
Provide gsd-xrandr icons (as links to preferences-desktop-display)
Status: RESOLVED INVALID
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2011-02-18 01:15 UTC by Vincent Untz
Modified: 2012-10-11 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (56.28 KB, image/png)
2011-02-18 01:16 UTC, Vincent Untz
Details

Description Vincent Untz 2011-02-18 01:15:34 UTC
Forwarding https://bugzilla.novell.com/show_bug.cgi?id=673106

The icon used by gnome-settings-daemon for xrandr is slightly different from the icon displayed to open the display settings. See attached screenshot.

We can simply choose to create gsd-xrandr icons, that would be links to preferences-desktop-display. Or we can fix g-s-d to use preferences-desktop-display instead of gsd-xrandr. This second solution isn't really perfect, though, as the hicolor icon is shipped in gnome-control-center...
Comment 1 Vincent Untz 2011-02-18 01:16:03 UTC
Created attachment 181184 [details]
screenshot
Comment 2 Jakub Steiner 2011-02-18 12:29:53 UTC
I don't quite get what you mean by 'create gsd-xrandr icons'. 

I can't see the current situation as confusing at all. The panel applet and the control center settings do pretty much the same thing, but with a different UI. The icons use the same metaphor, but have a slightly different color map. Where's the possible confusion exactly?

At the same time, I don't mind having both use preferences-desktop-display. In any case, I don't see this as a gnome-icon-theme issue?
Comment 3 Vincent Untz 2011-02-18 14:32:00 UTC
(In reply to comment #2)
> I don't quite get what you mean by 'create gsd-xrandr icons'. 

I mean just having gsd-xrandr symlinks to preferences-desktop-display. We don't want a new icon, we just want to use the same :-)

> I can't see the current situation as confusing at all. The panel applet and the
> control center settings do pretty much the same thing, but with a different UI.
> The icons use the same metaphor, but have a slightly different color map.
> Where's the possible confusion exactly?

I don't think it's confusing either -- the downstream reporter  believes so, but I think it's just not consistent.

> At the same time, I don't mind having both use preferences-desktop-display. In
> any case, I don't see this as a gnome-icon-theme issue?

Here's the thing: the current icon (preferences-desktop-display) is shipped in gnome-control-center. And gnome-settings-daemon doesn't depend on gnome-control-center, so it can't assume this icon is installed. That's why gnome-settings-daemon ships its own gsd-xrandr icons, I guess.

Now, gnome-icon-theme could fix this because it also provides preferences-desktop-display icons. On top of that, it could provide gsd-xrandr symlinks to the preferences-desktop-display icons. A bit like the gucharmap symlinks it installs.

Maybe it should be done in icon-naming-utils, though? Don't know how to best handle that.
Comment 4 Jakub Steiner 2011-02-18 15:14:14 UTC
preferences-desktop-display ships with gnome-icon-theme as far as I can tell...
Comment 5 Vincent Untz 2011-02-18 17:22:15 UTC
(In reply to comment #4)
> preferences-desktop-display ships with gnome-icon-theme as far as I can tell...

The one in hicolor is from gnome-control-center :-) And you can't assume that the user will have a theme inheriting from the gnome one.
Comment 6 Will Derksen 2011-02-19 05:30:15 UTC
Thanks for the quick handling of the regarding bug.

An inconsistent use of icons lead to confusion. 
Hence the term confusion in my downstream bug description.
Comment 7 Lapo Calamandrei 2012-10-11 14:46:35 UTC
This one seems not related and resolved now, closing. Fell free to reopen if I'm wrong.