After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642624 - do not run introspection tests if introspection was not enabled
do not run introspection tests if introspection was not enabled
Status: RESOLVED OBSOLETE
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-17 21:34 UTC by Peter Hjalmarsson
Modified: 2012-02-10 08:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch against master to diable introspection tests when instrospection support ain't built. (1.08 KB, patch)
2011-02-17 21:34 UTC, Peter Hjalmarsson 		none Details | Review

Description Peter Hjalmarsson 2011-02-17 21:34:20 UTC 
Created attachment 181175 [details] [review]
Patch against master to diable introspection tests when instrospection support ain't built.

If you do "./configure --disable-introspection && make check" then the testsuite will fail because it still tries to run the tests that needs introspection.

This holds true for both master and pygobject-2-28.

This is a upstreaming of gentoo bug #344341
Comment 1 johnp 2011-03-21 16:31:06 UTC 
Comment on attachment 181175 [details] [review]
Patch against master to diable introspection tests when instrospection support ain't built.

>From d492fdba302ab9b7eeca0eb8944b82185a997214 Mon Sep 17 00:00:00 2001
>From: Peter Hjalmarsson <xake@rymdraket.net>
>Date: Thu, 17 Feb 2011 22:29:41 +0100
>Subject: [PATCH] Do not run introspection-tests if introspection was disabled
>
>Without this tests fails for people passing --disable-introspection
>to configure.
>
>Thanks Dustin Polke fo the tip.
>---
> tests/Makefile.am |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/tests/Makefile.am b/tests/Makefile.am
>index c49a768..ecc0188 100644
>--- a/tests/Makefile.am
>+++ b/tests/Makefile.am
>@@ -111,7 +111,7 @@ RUN_TESTS_ENV_VARS= \
> 	XDG_DATA_DIRS=$$XDG_DATA_DIRS:/usr/share
> RUN_TESTS_LAUNCH=$(RUN_TESTS_ENV_VARS) $(DBUS_LAUNCH) $(EXEC_NAME) $(PYTHON) $(srcdir)/runtests.py
> 
>-check-local: $(LTLIBRARIES:.la=.so) Regress-1.0.typelib GIMarshallingTests-1.0.typelib gschemas.compiled
>+check-local: $(LTLIBRARIES:.la=.so) @ENABLE_INTROSPECTION_TRUE@Regress-1.0.typelib GIMarshallingTests-1.0.typelib gschemas.compiled

How does this work?  It looks like it just appends the value of @ENABLE_INTROSPECTION_TRUE@ to Regress-1.0.typelib.  We usually have a conditional that sets a variable (like we do for $(TEST_FILES_*).

> 	TEST_FILES="$(TEST_FILES_STATIC)" $(RUN_TESTS_LAUNCH)
> 	TEST_FILES="$(TEST_FILES_GI)" $(RUN_TESTS_LAUNCH)
> 
>-- 
>1.7.4.1
>
Comment 2 Tobias Mueller 2011-07-03 12:05:04 UTC 
Peter, can you report back?
Comment 3 Tobias Mueller 2012-01-22 13:32:56 UTC 
Peter, ping.
Comment 4 Martin Pitt 2012-02-10 08:12:58 UTC 
pygobject 3.0 and later are GI only, so this does not make sense for these versions any more, closing. Thanks!