After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642593 - Annotations needed for pango layout out parameters
Annotations needed for pango layout out parameters
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-17 17:42 UTC by johnp
Modified: 2011-03-02 21:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[gi] add out annotations to pango layout API (10.18 KB, patch)
2011-02-17 17:43 UTC, johnp 		none Details | Review

Description johnp 2011-02-17 17:42:01 UTC 
I was implementing a gtkprint demo for pygobject introspection and ran into issues calling PangoLayout.get_pixel_size.  All of the API in pango-layout.c that had out values needed to be annotated.  Patch to follow.
Comment 1 johnp 2011-02-17 17:43:04 UTC 
Created attachment 181154 [details] [review]
[gi] add out annotations to pango layout API
Comment 2 johnp 2011-02-17 17:45:34 UTC 
Tested the above patch.  There is most likely more annotations needed as this one only covers the out params.  I also noticed a lot of warnings from gir parser where other Pango API needs transfer annotations.  I can look into it but perhaps someone who is an expert at Pango may want to have a look also.
Comment 3 Behdad Esfahbod 2011-02-17 19:41:32 UTC 
I'm not well-versed in g-i either, but looks fine.  If it works for you, works for me :).  Please commit.
Comment 4 Behdad Esfahbod 2011-03-02 21:33:13 UTC 
Pushed.  Thanks.