After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642567 - Add Unity quicklist support
Add Unity quicklist support
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: screenshot
trunk
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-17 13:18 UTC by Didier Roche
Modified: 2011-09-26 21:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add unity quicklist support (940 bytes, patch)
2011-02-17 13:18 UTC, Didier Roche
reviewed Details | Review
Add unity quicklist support (1015 bytes, patch)
2011-03-22 15:21 UTC, Didier Roche
committed Details | Review

Description Didier Roche 2011-02-17 13:18:17 UTC
Created attachment 181123 [details] [review]
Add unity quicklist support

In Unity, we have a feature that enables static Quicklist entries. Those entries are always displayed on right click once the application is added to the launcher.

This patch adds two entries to gnome-screenshot quicklist in Unity:
- take the whole screen
- take the current window

If you need any other information, do not hesitate.
Comment 1 Emmanuele Bassi (:ebassi) 2011-02-17 13:58:42 UTC
Review of attachment 181123 [details] [review]:

generally, I don't see anything bad about this.

::: gnome-utils-2.32.0.orig/gnome-screenshot/gnome-screenshot.desktop.in
@@ +18,3 @@
+_Name=Take a screenshot of the whole screen
+Exec=gnome-screenshot
+OnlyShowIn=Unity

ugh. this should be X-Unity, unless you amended the spec to add Unity to the list of platforms.
Comment 2 Ted Gould 2011-02-17 15:10:00 UTC
Sorry, I didn't realize there was a list of OnlyShowIn keys.  I've submitted a patch to add Unity to that list.

   http://lists.freedesktop.org/archives/xdg/2011-February/011812.html

Hopefully this can get resolved quickly.  Thanks for looking at the patch!
Comment 3 Didier Roche 2011-03-22 15:21:07 UTC
Created attachment 184084 [details] [review]
Add unity quicklist support

From the discussion, a X- decision has been target as OnlyShowIn not suit Unity in this case. Updated the patch
Comment 4 Emmanuele Bassi (:ebassi) 2011-03-22 15:52:06 UTC
Review of attachment 184084 [details] [review]:

looks okay to me; if you want to land this before code freeze you'll have to do it now :-)
Comment 5 Emmanuele Bassi (:ebassi) 2011-03-22 15:52:16 UTC
Review of attachment 184084 [details] [review]:

looks okay to me; if you want to land this before code freeze you'll have to do it now :-)
Comment 6 Didier Roche 2011-03-22 17:11:24 UTC
excellent, thanks a lot (I don't have gnome commit rights on GNOME git, so if you can land it :))
Comment 7 Cosimo Cecchi 2011-09-17 03:13:14 UTC
Comment on attachment 184084 [details] [review]
Add unity quicklist support

This will have to wait after we branch now; as it adds new strings.
Comment 8 Cosimo Cecchi 2011-09-26 21:08:17 UTC
Pushed now to master, as gnome-utils branched.