Created attachment 181113 [details] [review]
Show a dialog after login the first time we fall back to gnome-fallback

This is based on the mockups in:

 http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/session/fallback.png

Review of attachment 181113 [details] [review]:

Thanks!

I was wondering whether it's worth shipping a directly rendered png instead of the svg. But the svg is probably small enough so that it wouldn't matter much.

::: gnome-session/gsm-manager.c
@@ +1225,3 @@
+
+        gtk_message_dialog_format_secondary_markup (GTK_MESSAGE_DIALOG (dialog),
+                                                    description);

Please add: if (description)

@@ +1229,3 @@
+        hbox = gtk_message_dialog_get_message_area (GTK_MESSAGE_DIALOG (dialog));
+
+        link = gtk_link_button_new_with_label (uri, link_text);

Please add:
 if (uri && link_text)
 else if (uri)
   link = gtk_link_button_new (uri);

@@ +1434,3 @@
                 break;
         case GSM_MANAGER_PHASE_RUNNING:
+                possibly_show_fallback_dialog (manager);

I was thinking we could show it a bit earlier, in GSM_MANAGER_PHASE_WINDOW_MANAGER+1 and block login there if we want to avoid having all kind of other apps loading while this window is shown. Would that make sense?

Created attachment 181119 [details] [review]
Show a dialog after login the first time we fall back to gnome-fallback

This is based on the mockups in:

 http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/session/fallback.png

Comment on attachment 181119 [details] [review]
Show a dialog after login the first time we fall back to gnome-fallback

Thanks, please commit!

Comment on attachment 181119 [details] [review]
Show a dialog after login the first time we fall back to gnome-fallback

Attachment 181119 [details] pushed as bad81e2 - Show a dialog after login the first time we fall back to gnome-fallback

Created attachment 181126 [details] [review]
Store svg compressed

I tried to move the dialog to earlier, but it came up in a weird position. And anyway, it looks like it shows up pretty early (before panel is visible anyway) already, so i think that is fine.

However, we should probably save the svg compresses, see patch.

I think this is all done, right ? Any reason to keep this open ?