After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642511 - nautilus-autorun-software should execute autorun.sh using /bin/sh
nautilus-autorun-software should execute autorun.sh using /bin/sh
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-16 21:28 UTC by Phillip Berndt
Modified: 2011-09-07 20:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for GIT revision 8f9dda634d5143dda92a8bf987ca083225ab174c (3.13 KB, patch)
2011-02-16 21:28 UTC, Phillip Berndt
committed Details | Review

Description Phillip Berndt 2011-02-16 21:28:03 UTC
Created attachment 181061 [details] [review]
Patch for GIT revision 8f9dda634d5143dda92a8bf987ca083225ab174c

Currently it tries to execute the file directly. In my interpretation, changing the behaviour to executing /bin/sh with autorun.sh as a parameter would neither do any harm, because the extension .sh should only be used for shell scripts, nor would it violate the specification [1].

Implementing this change would enable users to use autorun.sh scripts on FAT-formatted media (like my phone's sd-card). Currently, since FAT does not support execution bits, autorun fails.

Patch attached, but it's untested (I don't have the gnome build environment installed on my pc. Sorry)

[1] http://specifications.freedesktop.org/autostart-spec/autostart-spec-latest.html
Comment 1 Cosimo Cecchi 2011-09-07 20:02:29 UTC
Thanks for the patch, this is a good idea. I pushed your patch to git master.