After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642503 - Add DBus methods to nm-applet
Add DBus methods to nm-applet
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks: 621707
 
 
Reported: 2011-02-16 20:00 UTC by Giovanni Campagna
Modified: 2011-03-02 20:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Export DBus methods for wireless dialogs (7.91 KB, patch)
2011-02-16 20:00 UTC, Giovanni Campagna
none Details | Review

Description Giovanni Campagna 2011-02-16 20:00:38 UTC
As discussed on IRC, GNOME Shell in 3.0 will still rely on nm-applet for part of its UI, and needs a method to summon it.
Comment 1 Giovanni Campagna 2011-02-16 20:00:58 UTC
Created attachment 181046 [details] [review]
Export DBus methods for wireless dialogs

Export two void methods on the session bus, ConnectToHiddenNetwork
and CreateWirelessNetwork, that just open the respective wireless
dialog. These will be used by GNOME Shell.
Comment 2 Matthias Clasen 2011-02-28 22:58:39 UTC
Can we get this committed, please ? 
We are beyond ui freeze, and this blocks the network menu from landing in the shell
Comment 3 Dan Williams 2011-03-02 20:26:16 UTC
Cleaned up and pushed as:

afd0ee59a962f6eedc3dc1c41e065f9480b8468e

Thanks for the patch!  A few notes though:

1) the patch didn't respect the GConf preference for disabling creation of wifi networks which is necessary for managed installs; I've gone ahead and added a check to the D-Bus method that returns an error if this feature has been disabled via GConf or via NM permissions

2) it looks like the original patch would not have actually connected or created networks, as the dialog's "response" signal wasn't handled at all; so I've instead made the dbus method handlers call into the applet-device-wifi.c functions where the response can be handled correctly

3) I changed the bus name, object path, and interface; nm-applet itself, while the default implementation of an applet, isn't a freedesktop project, it's a GNOME project, and I think the bus name should reflect that.  Having a bus name of org.freedesktop.NetworkManager.XXX implies the API is somehow standarized or part of the core NM API, and I'd hope this is all temporary until we can get the shell indicator up to full functionality.