After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642501 - Folks needs API for attaching notes to a Contact
Folks needs API for attaching notes to a Contact
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on: 642513
Blocks:
 
 
Reported: 2011-02-16 19:46 UTC by Raul Gutierrez Segales
Modified: 2011-03-03 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add NoteOwner interface (5.90 KB, patch)
2011-03-03 01:24 UTC, Raul Gutierrez Segales
none Details | Review
Complements previous patch. (725 bytes, patch)
2011-03-03 17:25 UTC, Raul Gutierrez Segales
none Details | Review

Description Raul Gutierrez Segales 2011-02-16 19:46:52 UTC
We should probably start with an interface like

namespace Folks
{
interface NotesOwner :
{
    public string notes { get; set; }
}
}

and have Individual and each of the backends' Persona implementations implement
it.
Comment 1 Raul Gutierrez Segales 2011-03-03 01:24:01 UTC
Created attachment 182320 [details] [review]
Add NoteOwner interface

Simple interface to attach notes to a Persona and an Individual. As usual a UID is provided as way for backends to track their data.
Comment 2 Travis Reitter 2011-03-03 15:01:18 UTC
Thanks -- merged:

commit a41ee9f96eb9e7fdea67d8bf884670797eb24521
Author: Raul Gutierrez Segales <raul.gutierrez.segales@collabora.co.uk>
Date:   Thu Mar 3 01:17:38 2011 +0000

    Add NoteOwner interface
    
    Fixes: bgo#642501 - Folks needs API for attaching notes to a Contact

 NEWS                  |    1 +
 folks/Makefile.am     |    1 +
 folks/individual.vala |   45 ++++++++++++++++++++++++
 folks/note-owner.vala |   92 +++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 139 insertions(+), 0 deletions(-)
Comment 3 Raul Gutierrez Segales 2011-03-03 17:25:56 UTC
Created attachment 182374 [details] [review]
Complements previous patch.

Forgot to call _update_notes () from within _update_fields ().
Comment 4 Travis Reitter 2011-03-03 17:52:07 UTC
(In reply to comment #3)
> Created an attachment (id=182374) [details] [review]
> Complements previous patch.
> 
> Forgot to call _update_notes () from within _update_fields ().

Fixed. Thanks:

commit 5461da4b1b549bda90e99d15b15c82e6d7431532
Author: Raul Gutierrez Segales <raul.gutierrez.segales@collabora.co.uk>
Date:   Thu Mar 3 17:23:07 2011 +0000

    Ensure we update an Individual's notes along with the other fields.

 folks/individual.vala |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)