After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642488 - widgets/activieyentry.py: category never get added
widgets/activieyentry.py: category never get added
Status: RESOLVED FIXED
Product: hamster-applet
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: hamster-applet-maint
hamster-applet-maint
: 642304 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-16 18:11 UTC by Wim Vinckier
Modified: 2011-05-21 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch which fixes activityentry issue (557 bytes, patch)
2011-02-16 18:11 UTC, Wim Vinckier
committed Details | Review

Description Wim Vinckier 2011-02-16 18:11:23 UTC
Created attachment 181030 [details] [review]
patch which fixes activityentry issue

On line 116 (at least on the git version) there is 
 name = "%s@%s" % name, activity['category']
which has to be
 name = "%s@%s" % (name, activity['category'])
if you want a category to be added.

Otherwise you get something like:

Traceback (most recent call last):
  • File "/usr/bin/hamster-time-tracker", line 400 in on_switch_activity_clicked
    activity_name, temporary = self.new_name.get_value()
  • File "/usr/lib/pymodules/python2.6/hamster/widgets/activityentry.py", line 116 in get_value
    name = "%s@%s" % name, activity['category']
TypeError: not enough arguments for format string

Patch has been added.
Comment 1 Toms Bauģis 2011-05-13 19:35:35 UTC
cheers, fixed and pushed to git master!
Comment 2 Toms Bauģis 2011-05-13 19:35:57 UTC
Review of attachment 181030 [details] [review]:

pushed
Comment 3 Toms Bauģis 2011-05-21 13:29:16 UTC
*** Bug 642304 has been marked as a duplicate of this bug. ***