After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642462 - [patch] gnome-screensaver can be running twice
[patch] gnome-screensaver can be running twice
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: daemon
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-16 13:51 UTC by Marc Deslauriers
Modified: 2011-03-06 06:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
make sure gnome-screensaver cannot run twice (2.16 KB, patch)
2011-02-16 13:51 UTC, Marc Deslauriers 		none Details | Review

Description Marc Deslauriers 2011-02-16 13:51:35 UTC 
Created attachment 180994 [details] [review]
make sure gnome-screensaver cannot run twice

Because of a race condition, gnome-screensaver can be running more than once. This results in screen being locked again immediately after being unlocked.

See downstream bug report:
https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/556255

This patch corrects the issue by making sure that we bail out if we cannot become the primary owner of the bus name.

This patch is against the 2.30 branch, as I have no way to test HEAD. Code is head looks the same though, so it may be needed there also.

Thanks!
Comment 1 William Jon McCann 2011-03-06 06:30:55 UTC 
Nice catch.  Pushed to master with one small change.

commit 85d22a5d784b2b8201054257f8696138de1e1b70