After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642455 - sync window decoration style with mutter
sync window decoration style with mutter
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
[gnome3-important]
Depends on:
Blocks:
 
 
Reported: 2011-02-16 12:39 UTC by William Jon McCann
Modified: 2015-04-16 11:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't use an icon menu on the titlebar (882 bytes, patch)
2011-02-18 00:53 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2011-02-16 12:39:57 UTC 
It would be good to try to ensure that the window frame decorations are as similar as possible when switching between the default GNOME 3 and the fallback.  In a quick test I noticed

 * metacity still shows the window-icon-menu at the left of the titlebar
 * window titles don't appear properly centered
Comment 1 William Jon McCann 2011-02-18 00:53:40 UTC 
Created attachment 181182 [details] [review]
don't use an icon menu on the titlebar
Comment 2 Thomas Thurman 2011-02-18 18:26:48 UTC 
Review of attachment 181182 [details] [review]:

I can see people are going to complain about this as much as they did when Ubuntu moved the close button, but they can always add it back. Committing.
Comment 3 Matthias Clasen 2011-02-25 23:47:48 UTC 
This was committed in 1b84f7bf369ff991e2de0e8cd2e30e7788e6a041
closing, to get it off the list
Comment 4 William Jon McCann 2011-02-25 23:50:33 UTC 
Technically not finished:

 * mutter correctly centers title text
 * mutter uses different buttons

I think syncing the first is desirable and the second is not.
Comment 5 Frederic Peters 2011-03-17 20:12:40 UTC 
For reference the "correct centering" commit in mutter is:

commit e8e78ebfdd000ad85b0ec269b1a3420586750523
Author: Owen W. Taylor <otaylor@fishsoup.net>
Date:   Thu Aug 20 13:47:05 2009 -0400

    Add frame_x_center/frame_y_center variables for themes
    
    Sometimes you want to position something (usually the title) to be centered
    with respect to the entire frame instead of centered with respect to the
    individual piece currently being drawn.
    
    This patch adds frame_x_center and frame_y_center variables that represent
    the X/Y centers of the frame in the coordinate system of the piece being
    drawn.
    
    The theme version is bumped from 3.0 to 3.1 (3.0 is just the new version
    system, 3.1 will have all the features we add for Mutter-2.28.)
    position expressions
    
    https://bugzilla.gnome.org/show_bug.cgi?id=591842
Comment 6 André Klapper 2011-03-17 20:18:48 UTC 
[Removing gnome-target and adding whitespace entry [gnome3-important] as decided in today's release team meeting]