After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642412 - gstrtpbin with ignore-pt tries to use NULL stream->demux during uninitialization
gstrtpbin with ignore-pt tries to use NULL stream->demux during uninitialization
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.27
Other All
: Normal normal
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-15 19:06 UTC by Blaise Gassend
Modified: 2011-03-08 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Blaise Gassend 2011-02-15 19:06:50 UTC 
When using gstrtpbin with ignore-pt=true, the free_stream function tries to call gst_element_set_locked_state and gst_element_set_state on a stream->demux which is NULL.

The following patch should fix the problem:

--- ./gst/rtpmanager/gstrtpbin.c        2011-02-15 11:05:25.000000000 -0800
+++ ./gst/rtpmanager/gstrtpbin.c.orig   2011-02-15 11:04:57.000000000 -0800
@@ -1336,12 +1336,10 @@
   g_signal_handler_disconnect (stream->buffer, stream->buffer_ptreq_sig);
   g_signal_handler_disconnect (stream->buffer, stream->buffer_ntpstop_sig);
 
-  if (stream->demux)
-    gst_element_set_locked_state (stream->demux, TRUE);
+  gst_element_set_locked_state (stream->demux, TRUE);
   gst_element_set_locked_state (stream->buffer, TRUE);
 
-  if (stream->demux)
-    gst_element_set_state (stream->demux, GST_STATE_NULL);
+  gst_element_set_state (stream->demux, GST_STATE_NULL);
   gst_element_set_state (stream->buffer, GST_STATE_NULL);
 
   /* now remove this signal, we need this while going to NULL because it to
Comment 1 Wim Taymans 2011-02-22 12:32:13 UTC 
commit 0f88181f431ddf48092230bf84ca9e0bb9315c16
Author: Blaise Gassend <blaise at willowgarage dot com>
Date:   Tue Feb 22 13:29:26 2011 +0100

    rtpbin: handle NULL demux elements
    
    When using gstrtpbin with ignore-pt=true, the free_stream function tries to
    call gst_element_set_locked_state and gst_element_set_state on a stream->demux
    which is NULL.
    
    fixes #642412