GNOME Bugzilla – Bug 642333
st-entry: Add API to set an actor as primary/secondary icon
Last modified: 2011-02-21 16:55:06 UTC
The latest mockups for the search entry[0] use themed symbolic icons instead of the currently used close icon; to support this, add API to set the icons from a ClutterActor instead of a filename. [0] http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/searchbox.png
Created attachment 180863 [details] [review] st-entry: Add API to set an actor as primary/secondary icon Currently an entry's primary/secondary icon can only be set by filename. In order to allow using themed icons, add API to set a generic ClutterActor as icon.
Review of attachment 180863 [details] [review]: OK to commit except for minor style nits ::: src/st/st-entry.c @@ +960,3 @@ + _st_entry_set_icon (entry, &priv->primary_icon, icon); + +} Stray blank line @@ +967,3 @@ + * @icon: (allow-none): an #ClutterActor + * + * Set the primary icon of the entry to @icon secondary icon. (Would like it if the doc comments in this file described *what* primary and secondary icons were somewhere though existing problem.) @@ +981,3 @@ + _st_entry_set_icon (entry, &priv->secondary_icon, icon); + +} Another stray blank line
Attachment 180863 [details] pushed as bffe796 - st-entry: Add API to set an actor as primary/secondary icon