GNOME Bugzilla – Bug 642272
Add .lang file for J programming language
Last modified: 2012-08-20 20:49:10 UTC
Created attachment 180803 [details] language syntax definition for J programming language The IDE for the J progamming language is Gtk-based and uses Gtksourceview to provide syntax highlighting for J script files.
I'd appreciate any feedback on the attached .lang file. I can provide a .xml file too if that's of any interest.
Some comments: You are missing the license in the top, see other files for this. Do not indent after the comments keep it in the same level.
Created attachment 180809 [details] updated j.lang based on comments Added license and removed indenting under comments
More comments: you are using 2 space indentation in some places and 4 indentation in others. You should use always 2 space indentation.
Created attachment 185832 [details] updated j.lang with 2-space indents All indents in j.lang have been standardized as 2-spaces.
Created attachment 185833 [details] Updated j.lang to fix handling of Note Fix handling of multi-line (monadic) vs single line (dyadic) use of Note.
The file is missing "map-to" attributes in the style section which is needed to pick up default colors from the color-schemes included in gtksourceview
Created attachment 187875 [details] Adds "map-to"s in styles section
(In reply to comment #7) > The file is missing "map-to" attributes in the style section which is needed to > pick up default colors from the color-schemes included in gtksourceview Thanks. I've added a new version of the file with "map-to" attributes in the style section.
I think it would be nice if you could provide a way to contact you on the header together with the copyright (as it happens on the other files). Something like this: Authors: YOUR_NAME Copyright (C) 2011 NAME <EMAIL> If the developers for some reason want to change the license of gtksourceview, it seems they have to ask permission to every person that holds the copyright which would include you.
Created attachment 187876 [details] Add contact email
(In reply to comment #10) > I think it would be nice if you could provide a way to contact you on the > header together with the copyright (as it happens on the other files). > Something like this: > > Authors: YOUR_NAME > Copyright (C) 2011 NAME <EMAIL> > > If the developers for some reason want to change the license of gtksourceview, > it seems they have to ask permission to every person that holds the copyright > which would include you. Thanks. Done.
The file looks good to me, just some minor indentation issues. Could you please fix them and also provide a test file of no more than 10 lines to add to our testfiles.sh script?
Created attachment 188791 [details] fixed indents? I think this corrects the remaining indent issues?
Created attachment 188792 [details] Test file to add to testfiles.sh
Ignacio Casal, patch is available for review, tia.
Is there anything I can do to facilitate the inclusion of this in gtksourceview?
Sorry for the delay. I committed it