GNOME Bugzilla – Bug 642267
quick output device selection through applet
Last modified: 2013-04-18 14:37:16 UTC
Created attachment 180799 [details] [review] Allows quick switching between output devices from the applet This bug is directly related to this Ubuntu Brainstorm idea: http://brainstorm.ubuntu.com/idea/23754/ I often switch between using PC speakers and headphones. Currently, one must open up the Sound Preferences dialog, click on the Output tab, select the desired audio output device, then close the dialog. Having output devices listed directly in the applet menu would make this less of a chore. I have written a patch that does exactly this, attached to this bug report.
There's a similar request for gnome-shell's sound applet in bug 645798.
Review of attachment 180799 [details] [review]: Mostly coding style problems. Note that I haven't tested the UI yet, so it might need more work in that respect. ::: ../gnome-media-2.31.6/gnome-volume-control/src/gvc-stream-status-icon.c @@ +283,3 @@ + if (GVC_IS_MIXER_SINK (stream)) { + + Space before the opening bracket, not after. @@ +286,3 @@ + + OutputDeviceData* output_device_data; + Don't use malloc, use g_new0 insead. @@ +296,3 @@ + gtk_menu_shell_append (GTK_MENU_SHELL (output_device_submenu), item); + } + Extraneous empty line. @@ +337,3 @@ + gvc_stream_status_icon_populate_output_device_menu (icon, icon->priv->mixer_control, output_device_submenu); + + item = gtk_image_menu_item_new_with_mnemonic ("Output _Devices"); Need to set that to be translated. @@ +592,3 @@ + g_return_if_fail (GVC_STREAM_STATUS_ICON (icon)); + + if (control != NULL) { No need for braces for a single line condition. @@ +597,3 @@ + + if (icon->priv->mixer_control != NULL) { + g_return_if_fail (GVC_STREAM_STATUS_ICON (icon)); No need for an extra empty line here.
Mass reassign, sorry for the noise.
Marking as a duplicate of bug 645798 as there's no stand-alone sound applet, just the shell's applet in GNOME 3.8 and newer. *** This bug has been marked as a duplicate of bug 645798 ***