After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642212 - Console setup has several problems
Console setup has several problems
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
: 614917 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-13 04:48 UTC by Mike Gorse
Modified: 2011-03-19 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch. (2.48 KB, patch)
2011-02-13 04:59 UTC, Mike Gorse
none Details | Review
Updated patch. (2.30 KB, patch)
2011-02-17 09:35 UTC, Mike Gorse
committed Details | Review

Description Mike Gorse 2011-02-13 04:48:59 UTC
I've run into several problems with the console setup:

- If the user requests that Orca be automatically started at login, the console UI immediately sets /desktop/gnome/applications/at/visual/startup in gconf.  This causes gnome-session to immediately load Orca.  Meanwhile, the console UI is now offering to log the user out or waiting for the user to press return, but focus has moved to the new Orca (which does not know that the console Orca is running because it does not load the dbus service that the shell script uses to determine whether another Orca is running).  Delaying the gconf change until the console Orca is ready to exit will prevent the two instances from co-existing.

- After I fixed that issue, I noticed that the preferences dialogue was opening when I started Orca.  The console code is intended to prevent this but is not doing so.

- Finally, a setting is not being initialized, which causes a traceback when the other two issues are fixed.

The first issue is a problem with v2.32; I suspect that the latter issues only affect 2.91.x.
Comment 1 Mike Gorse 2011-02-13 04:59:43 UTC
Created attachment 180760 [details] [review]
Proposed patch.

I also modified the keyboard prompt to silence speech, since I didn't see any reason for it to behave differently from the other prompts and so it looked like a bug, but feel free to tell me to revert that part of the patch.
Comment 2 Mike Gorse 2011-02-17 09:35:28 UTC
Created attachment 181106 [details] [review]
Updated patch.

Updated patch to apply against current git, since one of the issues that it fixes is already committed (BGO#642285).
Comment 3 Joanmarie Diggs (IRC: joanie) 2011-02-21 20:54:51 UTC
Comment on attachment 181106 [details] [review]
Updated patch.

Thanks Mike. I've gone ahead and pushed it since I need to crank out the release.

http://git.gnome.org/browse/orca/commit/?id=03b6a60a1ab8589e4ab0ae7b13ec2e60d7bfdf44
Comment 4 Joanmarie Diggs (IRC: joanie) 2011-03-19 19:56:21 UTC
*** Bug 614917 has been marked as a duplicate of this bug. ***